Lapo Calamandrei [Mon, 18 Apr 2016 22:11:09 +0000 (00:11 +0200)]
Adwaita: fix infobar text color in backdrop windows
see https://bugzilla.gnome.org/show_bug.cgi?id=765213
Matthias Clasen [Mon, 18 Apr 2016 19:04:37 +0000 (15:04 -0400)]
font button: Convert from pango to css properly
This utility function should probably find a home somewhere else.
For now, this makes the deprecation warning go away.
Benjamin Otte [Mon, 18 Apr 2016 18:25:11 +0000 (20:25 +0200)]
cssimage: Warn if gradients only have 1 color stop
GTK <= 3.20 allowed that but the CSS spec and borwsers do not.
We might want to just remove that feature, but for now, we just warn.
Benjamin Otte [Sun, 27 Mar 2016 23:50:32 +0000 (01:50 +0200)]
theme: linear-gradient() needs 2 color-stops
So make sure our _solid() function gives it two.
Benjamin Otte [Sun, 27 Mar 2016 17:41:19 +0000 (19:41 +0200)]
theme: Split out _solid() function
The function creates a solid color image. Currently this is done with
linear-gradient().
Benjamin Otte [Sun, 3 Apr 2016 01:39:46 +0000 (03:39 +0200)]
win32 theme: Fix functions to not have spaces
CSS doesn't allow that (although GTK's CSS parser did so far not
complain).
Matthias Clasen [Mon, 18 Apr 2016 18:38:53 +0000 (14:38 -0400)]
Expand css style font tests
Test more of the syntax of the font: shorthand.
Matthias Clasen [Mon, 18 Apr 2016 18:38:12 +0000 (14:38 -0400)]
Fix a typo
We don't want to parse a weight twice, but a weight and a stretch.
Matthias Clasen [Mon, 18 Apr 2016 18:17:55 +0000 (14:17 -0400)]
HighContrast: Fix font: usage
Matthias Clasen [Mon, 18 Apr 2016 18:09:41 +0000 (14:09 -0400)]
Add backwards compat back
Apparently, there's lots of font: "pango font description" out there,
so keep parsing this, with a deprecation warning.
Matthias Clasen [Mon, 18 Apr 2016 15:45:55 +0000 (11:45 -0400)]
Adwaita: Fix use of font: shorthand
Matthias Clasen [Mon, 18 Apr 2016 15:43:29 +0000 (11:43 -0400)]
Fix parsing of the font: shorthand
Our code here was just throwing it at PangoFontDescription.
Fix this by parsing the various components ourselves.
Matthias Clasen [Mon, 18 Apr 2016 15:43:01 +0000 (11:43 -0400)]
Export some font parsing functions
These will be used for parsing the font: shorthand too.
Matthias Clasen [Mon, 18 Apr 2016 15:40:10 +0000 (11:40 -0400)]
Fix the css style font test
Setting the font: shorthand to something like smaller is not
in line with the css spec. Just set the font-size: property
for this.
Also fix the other font: shorthand to specify size and family
according to the css spec.
Matthias Clasen [Mon, 18 Apr 2016 13:43:10 +0000 (09:43 -0400)]
css style: Rename some static functions
Make the font property functions follow the general naming
scheme, and remove pango from the names.
Matthias Clasen [Mon, 18 Apr 2016 13:42:40 +0000 (09:42 -0400)]
Add docs for new API
Carlos Garnacho [Mon, 18 Apr 2016 13:10:49 +0000 (14:10 +0100)]
wayland: Improve checks when flushing scroll events
If we get gdk_wayland_seat_flush_frame_event() with no previous event to be
flushed, we fallback into the scroll event checks. However, there's no check
performed there as to whether it really scrolled, so it'd always send a smooth
scroll event with 0/0 deltas in this case.
This should be mostly harmless, but still, we should only end up emitting scroll
events if those really happened.
Carlos Garnacho [Mon, 18 Apr 2016 12:10:24 +0000 (13:10 +0100)]
wayland: Do not check the pointer focus when receiving wl_pointer.frame
The frame event is also meant to compress wl_pointer.leave events, at this
point the focus surface will be definitely NULL. In the end, wl_pointer.frame
should flush the last composed event despite the pointer focus.
https://bugzilla.gnome.org/show_bug.cgi?id=765065
Carlos Garnacho [Sun, 17 Apr 2016 20:19:58 +0000 (21:19 +0100)]
gdk: Make GDK_TOUCH_CANCEL be dealt with similarly to GDK_TOUCH_END
We must emit the cancel event with the same semantics, and towards the GdkWindow
that is currently under the touchpoint, so make proxy_button_event() deal with
GDK_TOUCH_CANCEL.
Fixes the GDK_TOUCH_CANCEL event being emitted only on the toplevel, which is
usually non-sufficient.
Matthias Clasen [Fri, 1 Apr 2016 01:35:43 +0000 (21:35 -0400)]
widget: Use gdk_pango_get_for_display
Matthias Clasen [Fri, 1 Apr 2016 01:33:03 +0000 (21:33 -0400)]
Add gdk_pango_context_get_for_display
This is the obvious 1 line equivalent of the for_screen function.
Piotr Drąg [Mon, 18 Apr 2016 00:36:20 +0000 (02:36 +0200)]
Updated Polish translation
Lapo Calamandrei [Sun, 17 Apr 2016 21:40:29 +0000 (23:40 +0200)]
Adwaita: cosmetics
Lapo Calamandrei [Sun, 17 Apr 2016 21:08:26 +0000 (23:08 +0200)]
Adwaita: colorbutton colorswatch shadow fix
reset colorswatch box-shadow on active and checked state as well
following latest style changes.
Lapo Calamandrei [Sun, 17 Apr 2016 20:46:48 +0000 (22:46 +0200)]
Adwaita: increase opacity on scale label and marks
using the same opacity as dim-label.
Piotr Drąg [Sun, 17 Apr 2016 18:22:47 +0000 (20:22 +0200)]
Updated POTFILES.in and POTFILES.skip
Matthias Clasen [Sun, 17 Apr 2016 17:41:29 +0000 (13:41 -0400)]
bloatpad: Make shortcuts window update
This tests the just added functionality to make shortcuts
track changes in their actions accelerators.
Matthias Clasen [Sun, 17 Apr 2016 17:38:51 +0000 (13:38 -0400)]
shortcuts: Follow changes of accels
Add a way to associate a detailed action name with a shortcut.
If the action name is set, update the accelerator whenever
accels change on the window that the shortcuts window is
associated with.
https://bugzilla.gnome.org/show_bug.cgi?id=764975
Matthias Clasen [Sun, 17 Apr 2016 14:22:59 +0000 (10:22 -0400)]
Add a help overlay to bloatpad
This will let us explore the (non-)interaction between
help overlays and editing shortcuts.
Lapo Calamandrei [Sun, 17 Apr 2016 16:39:07 +0000 (18:39 +0200)]
Adwaita: clean up pushed button mixin
Lapo Calamandrei [Sun, 17 Apr 2016 16:19:38 +0000 (18:19 +0200)]
Adwaita: fix scale slider border color
using the darker border color.
Lapo Calamandrei [Sun, 17 Apr 2016 16:17:07 +0000 (18:17 +0200)]
Adwaita: flatten colorswatches
Lapo Calamandrei [Sun, 17 Apr 2016 16:06:15 +0000 (18:06 +0200)]
Adwaita: more borders color tweaks
Lapo Calamandrei [Sun, 17 Apr 2016 13:26:22 +0000 (15:26 +0200)]
Adwaita: cosmetics
Lapo Calamandrei [Sun, 17 Apr 2016 13:24:57 +0000 (15:24 +0200)]
Adwaita: dark variant borders color tweaks
Lapo Calamandrei [Sun, 17 Apr 2016 13:21:31 +0000 (15:21 +0200)]
Adwaita: pushed button style tweak
use a solid background.
Lapo Calamandrei [Sun, 17 Apr 2016 13:06:13 +0000 (15:06 +0200)]
Adwaita: button style tweak
add a darker bottom border to buttons to add some depth.
Matthias Clasen [Sun, 17 Apr 2016 05:54:43 +0000 (01:54 -0400)]
Add some more accelerator / modifier tests
Matthias Clasen [Sun, 17 Apr 2016 05:50:23 +0000 (01:50 -0400)]
wayland: Make virtual modifier mapping more similar to X
Ignore virtual modifiers that are mapped to Mod1 (as Meta
often is), to avoid interfering with our fix interpretation
of Mod1 as Alt.
Matthias Clasen [Sun, 17 Apr 2016 05:09:32 +0000 (01:09 -0400)]
menuitem: Fix some possible problems with arrow_gadget
https://bugzilla.gnome.org/show_bug.cgi?id=765134 shows
a stacktrace where we end up with arrow_gadget being NULL
despite the conditions for its presence being satisfied.
This commit makes sure we call update_arrow_gadget() whenever
any of the conditions changes. This should fix the reported
crash.
Matthias Clasen [Sun, 17 Apr 2016 03:16:12 +0000 (23:16 -0400)]
wayland: Fix the map_virtual_modifiers implementation
We were not stripping real modifiers out, and thus always
thought there's a conflict when the passed in modifiers
included any real modifiers.
Bastien Nocera [Fri, 15 Apr 2016 10:13:34 +0000 (12:13 +0200)]
cups: Fix gettext usage
The previous patches didn't mark some strings as to be translated, and
tried to translate strings with a variable part already inside the
string, which isn't going to work.
Mark the strings as translatable with context, and also make sure to
translate static strings when getting them out of their structure.
https://bugzilla.gnome.org/show_bug.cgi?id=764585
Lapo Calamandrei [Sat, 16 Apr 2016 12:42:13 +0000 (14:42 +0200)]
Adwaita: ensure dialogs titlebar rounded corners
broken from my previous commit about rounded corners, dialogs
doesn't use the "window" node, but the "dialog" node, so use the
.background styleclass in the selectors which is more generic.
Lapo Calamandrei [Sat, 16 Apr 2016 12:32:04 +0000 (14:32 +0200)]
Adwaita: more border color tweaking
Lapo Calamandrei [Sat, 16 Apr 2016 12:28:29 +0000 (14:28 +0200)]
Adwaita: lighten border color a bit
Lapo Calamandrei [Sat, 16 Apr 2016 11:41:32 +0000 (13:41 +0200)]
Adwaita: flatten the switch base
Lapo Calamandrei [Sat, 16 Apr 2016 11:35:48 +0000 (13:35 +0200)]
Adwaita: flatten entries and similar widgets
Lapo Calamandrei [Sat, 16 Apr 2016 11:21:39 +0000 (13:21 +0200)]
Adwaita: delete unused mixin
Lapo Calamandrei [Sat, 16 Apr 2016 11:19:41 +0000 (13:19 +0200)]
Adwaita: flatten scale and progressbar trough
Lapo Calamandrei [Sat, 16 Apr 2016 09:58:14 +0000 (11:58 +0200)]
Adwaita: ensure titlebar corners are not rounded...
...when the window is maximized or tiled, by using more specific
selectors, since there were cases of erroneusly rounded corners.
See https://bugzilla.gnome.org/show_bug.cgi?id=765038
Matthias Clasen [Sat, 16 Apr 2016 02:20:25 +0000 (22:20 -0400)]
wayland: Implement virtual modifiers
Since Wayland is using libxkbcommon, it inherits X unfortunate
real/virtual modifier distinction, so we have to do the same
gymnastics we do for X to map between the two.
This should fix matching of accelerators using virtual modifiers
(modulo gnome-shell bugs regarding the handling of Super).
https://bugzilla.gnome.org/show_bug.cgi?id=764424
Matthias Clasen [Sat, 16 Apr 2016 02:13:30 +0000 (22:13 -0400)]
Clarify docs a bit
The wording here was just awkward: TRUE is returned if... Note that
FALSE is also returned if...
Руслан Ижбулатов [Fri, 15 Apr 2016 17:37:49 +0000 (17:37 +0000)]
gtk-builder-tool: use g_printf() instead of g_print()
1) g_print() can be redirected
2) g_print() does some extra processing, such as character set conversion.
Specifically, on W32 it will detect system codepage via GetACP(),
and will convert UTF-8 output into that codepage, even though
the output should stay unchanged (whether gtk-builder-tool interprets
strings from ui files as UTF-8 is a separate matter).
https://bugzilla.gnome.org/show_bug.cgi?id=765118
Lapo Calamandrei [Fri, 15 Apr 2016 16:28:26 +0000 (18:28 +0200)]
Adwaita: really fix solid-csd
add a specificity bump hack in the titlebar solid-csd styling to
avoid being overridden by the split titlebar theme logic.
Lapo Calamandrei [Fri, 15 Apr 2016 16:00:37 +0000 (18:00 +0200)]
Adwaita: fix backdrop solid-csd
titlebar rounded corners were not overridden for backdrop state.
Lapo Calamandrei [Fri, 15 Apr 2016 14:51:29 +0000 (16:51 +0200)]
Adwaita: better solid-csd styling
Jeremy Tan [Fri, 15 Apr 2016 11:22:20 +0000 (19:22 +0800)]
GDK W32: Fix positioning of reparented window
MoveWindow should not be used over the pre-existing move/resize
functions, which already correctly position a window with respect
to its parent, while also taking into account the size of window
decorations.
https://bugzilla.gnome.org/show_bug.cgi?id=765100
Matthias Clasen [Fri, 15 Apr 2016 02:52:59 +0000 (22:52 -0400)]
inspector: Don't lie with statistics
If we don't have statistics, despite GOBJECT_DEBUG being set,
explain how to fix this.
Matthias Clasen [Thu, 14 Apr 2016 19:30:59 +0000 (15:30 -0400)]
GtkBuilder: Mention how GVariant properties are parsed
Benjamin Otte [Thu, 14 Apr 2016 19:03:27 +0000 (21:03 +0200)]
iconhelper: Invalidate on clear()
When clearing the icon helper, we need to invalidate it. Otherwise the
previous icon keeps lingering along.
This is not relevant inside gtkiconhelper.c where other code causes the
invalidation, but happens when external code calls
_gtk_icon_helper_clear().
https://bugzilla.gnome.org/show_bug.cgi?id=765066
Matt Watson [Wed, 13 Apr 2016 19:46:01 +0000 (12:46 -0700)]
Fix label css test
The default font size of 10pt will now properly render as 13.33px,
but we shouldn't use the default anyway as that can be controlled
by user settings
Felipe Borges [Wed, 13 Apr 2016 18:00:19 +0000 (20:00 +0200)]
cups: make string non-literals translatable again
Notice that C_ just takes string literals as arguments.
https://bugzilla.gnome.org/show_bug.cgi?id=764585
Sebastien Bacher [Thu, 17 Mar 2016 12:57:41 +0000 (13:57 +0100)]
gtkplacessidebar: don't margins in the code
those should rather be defined by the theme
https://bugzilla.gnome.org/show_bug.cgi?id=763768
Carlos Garnacho [Thu, 14 Apr 2016 09:05:00 +0000 (11:05 +0200)]
GtkWindow: Ensure the toplevel is realized before realizing popovers
Otherwise those get a NULL parent window, which is toplevel-y enough
to disembody the popover.
https://bugzilla.gnome.org/show_bug.cgi?id=764060
Jeremy Tan [Wed, 13 Apr 2016 13:39:46 +0000 (21:39 +0800)]
GDK W32: Fix bounding rect calculation on window creation The bounding rect specifies the top left and bottom right corners - the bottom right corner must account for the current window position.
https://bugzilla.gnome.org/show_bug.cgi?id=764996
Piotr Drąg [Wed, 13 Apr 2016 13:29:48 +0000 (15:29 +0200)]
Updated POTFILES.skip
Felipe Borges [Tue, 12 Apr 2016 13:55:19 +0000 (15:55 +0200)]
cups: Fix more "format not a string literal" error
https://bugzilla.gnome.org/show_bug.cgi?id=764585
YunQiang Su [Wed, 13 Apr 2016 12:14:44 +0000 (20:14 +0800)]
update zh_CN translation
YunQiang Su [Wed, 13 Apr 2016 08:41:00 +0000 (16:41 +0800)]
update zh_CN translation
Matt Watson [Tue, 12 Apr 2016 04:35:09 +0000 (21:35 -0700)]
reftests: test rem size
Matt Watson [Mon, 11 Apr 2016 23:17:08 +0000 (16:17 -0700)]
reftests: test em size
Matt Watson [Tue, 12 Apr 2016 01:18:31 +0000 (18:18 -0700)]
css: always get default font size in pixels
Fixes a couple bugs...
- Pixel font sizes in css would render as point sizes.
- For em font sizes, where the parent size was set and not default, we would
incorrectly convert a pixel value from points to pixels.
We'll always grab the default font size in pixels so we don't keep confusing
things.
Worth noting that gtk css font-size will still behave differently than the
web. Pango interprets font-size differently.
Sébastien Wilmet [Sun, 10 Apr 2016 14:58:49 +0000 (16:58 +0200)]
app: add missing g_returns
And have the g_returns in the same order as the function parameters.
https://bugzilla.gnome.org/show_bug.cgi?id=764846
Руслан Ижбулатов [Mon, 11 Apr 2016 07:07:14 +0000 (07:07 +0000)]
GDK W32: Deduplicate reparenting
gdk_window_reparent() already changes children list for old and new parent.
Doing so twice results in a circular reference in the list, which can hang
the application later, for example in gtk_window_show().
https://bugzilla.gnome.org/show_bug.cgi?id=764845
Rico Tzschichholz [Tue, 12 Apr 2016 11:30:04 +0000 (13:30 +0200)]
gtk: Annotate GtkFlowBoxCreateWidgetFunc as "transfer full"
Balló György [Sun, 10 Apr 2016 19:42:04 +0000 (21:42 +0200)]
GtkTrayIcon: fix uninitialised variable
https://bugzilla.gnome.org/show_bug.cgi?id=764863
Mohammed Sadik [Tue, 12 Apr 2016 01:24:35 +0000 (06:54 +0530)]
documentation: trivial typo fixes in GtkWidget
https://bugzilla.gnome.org/show_bug.cgi?id=764925
Ignacio Casal Quinteiro [Mon, 11 Apr 2016 20:22:37 +0000 (22:22 +0200)]
win32: rollback change and use _gdk_display
This makes usage of _gdk_display again when creating a window.
This is needed because there is a window created when the display
is being initialized, so it becomes a chicken and egg problem.
For now we roll back this to fix the wintab crash but we might
want to fix this again in the future by improving the wintab
initialization.
https://bugzilla.gnome.org/show_bug.cgi?id=764664
Ignacio Casal Quinteiro [Mon, 11 Apr 2016 20:22:23 +0000 (22:22 +0200)]
win32: add missing empty lines
Arash Mousavi [Mon, 11 Apr 2016 18:26:23 +0000 (22:56 +0430)]
Update Persian translations
Matthias Clasen [Mon, 11 Apr 2016 15:57:46 +0000 (11:57 -0400)]
gdkdevice: Expose tool as property
This may occasionally be useful.
Matthias Clasen [Mon, 11 Apr 2016 11:52:39 +0000 (07:52 -0400)]
listbox: Fix css node ordering
When inserting a child at the top, we were not inserting its
css node properly.
https://bugzilla.gnome.org/show_bug.cgi?id=764710
Mohammed Sadik [Sun, 10 Apr 2016 06:19:20 +0000 (11:49 +0530)]
broadway: fix documentation
broadway backend has 0 as the default display port,
which maps to tcp port 8080.
https://bugzilla.gnome.org/show_bug.cgi?id=764835
Emmanuele Bassi [Sun, 10 Apr 2016 17:41:23 +0000 (18:41 +0100)]
recent-manager: Always ensure that size is reset on creation
Whenever we create a new GBookmarkFile, we need to set the size to 0.
https://bugzilla.gnome.org/show_bug.cgi?id=620065
Emmanuele Bassi [Sun, 10 Apr 2016 17:39:33 +0000 (18:39 +0100)]
recent-manager: Fix the error domain and message on move_item()
Using NOT_FOUND when moving is wrong and unhelpful.
https://bugzilla.gnome.org/show_bug.cgi?id=620065
Emmanuele Bassi [Sun, 10 Apr 2016 17:28:01 +0000 (18:28 +0100)]
recent-manager: Emit ::changed on file deletion
This will clear out the list of recently used files, and will allow GVFS
to handle this case.
https://bugzilla.gnome.org/show_bug.cgi?id=693077
Emmanuele Bassi [Sun, 10 Apr 2016 16:51:58 +0000 (17:51 +0100)]
Assign a recent manager if one is set
The GtkRecentAction implementation ignored a GtkRecentManager passed to
its :manager property.
https://bugzilla.gnome.org/show_bug.cgi?id=620065
Sébastien Wilmet [Sun, 10 Apr 2016 09:08:57 +0000 (11:08 +0200)]
app: minor code improvements
- use GDK_EVENT_PROPAGATE
- pass better zero-values to gtk_init(), since the parameters are
pointers.
https://bugzilla.gnome.org/show_bug.cgi?id=764846
Sébastien Wilmet [Sun, 10 Apr 2016 10:41:09 +0000 (12:41 +0200)]
app: improve code of extract_accels_from_menu()
sub_model is clearer than "m". And we don't use the key, so we can pass
NULL instead.
https://bugzilla.gnome.org/show_bug.cgi?id=764846
Sébastien Wilmet [Sun, 10 Apr 2016 12:15:35 +0000 (14:15 +0200)]
app: use g_set_object()
https://bugzilla.gnome.org/show_bug.cgi?id=764846
Sébastien Wilmet [Sun, 10 Apr 2016 10:28:14 +0000 (12:28 +0200)]
app: don't use deprecated function
gtk_application_add_accelerator() is deprecated, but was still used
inside IGNORE_DEPRECATIONS's.
https://bugzilla.gnome.org/show_bug.cgi?id=764846
Sébastien Wilmet [Sun, 10 Apr 2016 10:56:39 +0000 (12:56 +0200)]
app: improve doc of gtk_application_get_window_by_id()
https://bugzilla.gnome.org/show_bug.cgi?id=764846
Sébastien Wilmet [Sat, 9 Apr 2016 15:42:12 +0000 (17:42 +0200)]
app: improve doc of gtk_application_set_accels_for_action()
When reading the API for the first time I didn't know what was the
"detailed" action name.
https://bugzilla.gnome.org/show_bug.cgi?id=764846
Sébastien Wilmet [Sat, 9 Apr 2016 10:50:43 +0000 (12:50 +0200)]
app: avoid code duplication for setting accels
The implementation of the deprecated functions is now based on the
non-deprecated gtk_application_set_accels_for_action().
https://bugzilla.gnome.org/show_bug.cgi?id=764846
Lukas K [Sun, 3 Apr 2016 13:31:05 +0000 (15:31 +0200)]
Fix gtk_scrollable_get_border annotation
https://bugzilla.gnome.org/show_bug.cgi?id=764540
Zahari Yurukov [Sun, 10 Apr 2016 13:31:35 +0000 (16:31 +0300)]
Updated Bulgarian translation
Friedrich Beckmann [Thu, 7 Apr 2016 07:33:41 +0000 (09:33 +0200)]
quartz: zoom/rotate change compile/runtime check from 10.7 to 10.8
The zoom/rotate change for quartz does not build on 10.7. This change
adds zoom/rotate support in quartz only for 10.8 and following. The
problems is described here:
https://bugzilla.gnome.org/show_bug.cgi?id=760276 and here
https://trac.macports.org/ticket/51052
NSEventPhaseMayBegin was only introduced in 10.8 although documentation
says it is introduced in 10.7. Tests on 10.7 indicate that the phase
property for the Magnify event is not supported at all on 10.7
Matthias Clasen [Sat, 9 Apr 2016 21:35:58 +0000 (17:35 -0400)]
Add a note about GDK_AXIS_X/Y
These axes mmay or may not be present, best to ignore them.
Matthias Clasen [Sat, 9 Apr 2016 21:31:39 +0000 (17:31 -0400)]
wayland: Keyboard don't have x/y
These axes are not very useful in the first place, but on a
keyboard they just don't make any sense at all.
Matthias Clasen [Sat, 9 Apr 2016 21:04:57 +0000 (17:04 -0400)]
Mention geometry handling changes in release notes